Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(work in progress) add: ЙЦУКЕН keyboard layout #1

Merged
merged 1 commit into from
May 12, 2024
Merged

(work in progress) add: ЙЦУКЕН keyboard layout #1

merged 1 commit into from
May 12, 2024

Conversation

K0stov
Copy link
Contributor

@K0stov K0stov commented May 12, 2024

Hi! Good job on your keyboard heatmap, it's been useful to me. I like that the user can set their own layout.

I've attempted to add the ЙЦУКЕН keyboard layout, used in Russian:

ЙЦУКЕНГШЩЗХЪ
ФЫВАПРОЛДЖЭЁ
ЯЧСМИТЬБЮ___

The layout spans 12 characters on the top row, so I've extended the grid width from 10 to 12 characters.

There are two problems with this that I haven't yet solved:

  • the heatmap is misaligned beyond the first 10 characters. When the 11th character (Х) appears in the text, it is instead heatmapped to Ф on the home row.
  • the layout cannot be used in Ortho Fall (2022_1/a_ortho/ortho_typing.html), because the characters falling are in Latin. The Russian alphabet is as follows: АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ

If you have the time, I'd appreciate help with resolving them. Thank you!

Note: in this commit, the heatmap is misaligned beyond the first 10 characters.
@oha-Ohashi
Copy link
Owner

I'm sorry but I don't have time for this for some reasons.
Your PR will be accepted because it seems to have no problem, but further approaches like adding Cyrillic alphabets cannot be done.
This project is under MIT license and I want you feel free to modify it and uploading with your domain.

I would wish your happy keyboard life!!
Plus, please let me know about your keyboard projects if you would like!

@oha-Ohashi oha-Ohashi merged commit 47f08c1 into oha-Ohashi:main May 12, 2024
@K0stov
Copy link
Contributor Author

K0stov commented May 12, 2024

I believe the issue is located in heatmap.min.js. I will try to solve it myself, but I cannot promise anything.

I would recommend you undo this commit for now, since the pull request is only for demonstrative purposes. This currently breaks not only ЙЦУКЕН, but all other layouts. (Try using QWERTY, inputting the character A and it will instead highlight D.)

If you find the time to help, it would be excellent. :)

@oha-Ohashi
Copy link
Owner

Thank you a lot for your advice 😃
This commit has been reverted at #2 .

If you find the time to help, it would be excellent. :)
It's hard for me to secure time for development for the time being. I wish I could 😭

@K0stov
Copy link
Contributor Author

K0stov commented May 12, 2024

Fixed in #3, check it out. :)

Plus, please let me know about your keyboard projects if you would like!

I work as a translator and I'm making a modified version of Colemak Mod-DH for the Serbian language, and this tool helped me immensely. I decided it would be useful to extend it to Russian and Belarusian. I know people who would benefit from it.

@oha-Ohashi
Copy link
Owner

Those words made me very proud 🥲
I'm so happy😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants