[APM] Fix for default fields in correlations view (elastic#91868)

ogupte · Feb 19, 2021 · c00cb8c · c00cb8c
1 parent 99a60ca
commit c00cb8c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/x-pack/plugins/apm/public/hooks/useLocalStorage.ts b/x-pack/plugins/apm/public/hooks/useLocalStorage.ts
@@ -5,12 +5,10 @@
  * 2.0.
  */
 
-import { useState, useEffect } from 'react';
+import { useState, useEffect, useCallback } from 'react';
 
 export function useLocalStorage<T>(key: string, defaultValue: T) {
-  const [item, setItem] = useState<T>(getFromStorage());
-
-  function getFromStorage() {
+  const getFromStorage = useCallback(() => {
     const storedItem = window.localStorage.getItem(key);
 
     let toStore: T = defaultValue;
@@ -26,7 +24,9 @@ export function useLocalStorage<T>(key: string, defaultValue: T) {
     }
 
     return toStore;
-  }
+  }, [key, defaultValue]);
+
+  const [item, setItem] = useState<T>(getFromStorage());
 
   const updateFromStorage = () => {
     const storedItem = getFromStorage();
@@ -51,5 +51,9 @@ export function useLocalStorage<T>(key: string, defaultValue: T) {
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
+  useEffect(() => {
+    setItem(getFromStorage());
+  }, [getFromStorage]);
+
   return [item, saveToStorage] as const;
 }