Warm when git feature is disabled instead of ignoring flags

[ariasuni]

The flags --git and --git-ignore are caught early during options parsing, so no more checking for git feature is done elsewhere.

Since --git-ignore depends on git too since recently, remove it from help when git feature is disabled.

Extended attributes now don’t artificially depends on git feature being enabled.

Tell if exa was compiled with git support or not when using --help

Tell in the man that some flags needs exa built with git support

Fix #761

[ariasuni]

I realize that the way this is done is not ideal at all.

Aborting with an error when git is disabled may prevent sharing alias using git-related features between different machines, so I guess it should be ignored. But then if it’s ignored, we need to take any other occasion to explain the user what’s going on. This is why I believe that instead of --help not displaying anything about --git and --git-ignore, which may confuse users who know about the git options, it should tell user explicitly that these options exist but are unavailable.

These thoughts are related to the fact that some distributor may not enable git, like it was done for Debian/Ubuntu.

[ogham]

Thanks for this!

This is why I believe that instead of --help not displaying anything about --git and --git-ignore, which may confuse users who know about the git options, it should tell user explicitly that these options exist but are unavailable.

Yeah, this was a big downside of omitting them from the --help output. It's not an unknown argument, it's a known one, just a disabled one. The new message is much better.

Aborting with an error when git is disabled may prevent sharing alias using git-related features between different machines, so I guess it should be ignored. But then if it’s ignored, we need to take any other occasion to explain the user what’s going on.

I think if exa started printing out warnings (Warning: exa was built without Git support; ignoring --git option) upon startup, users would want to fix their aliases anyway, because the warnings would get annoying.