Upgrade both Rust version and edition (and fix some lints) #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariasuni
approved these changes
Feb 20, 2023
Tyrubias
force-pushed
the
upgrade-and-cleanup
branch
from
362393a to
eba3646
Compare
|
Could you update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
exato use Rust 1.63.0 as well as Rust Edition 2021. It also fixes a number of Clippy warnings. Note that we do not upgrade to Rust 1.64.0 here because it increases theglibcand Linux kernel requirements, which would breakexafor users on older platforms without necessarily providing a benefit in terms of developer experience or new APIs.This is my first Rust contribution. I did my best to follow the atomic commits principle to make it easier to review my PR. I'm inexperienced with open-source contributions and would love any feedback you may have. Thank you!