Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): add omitempty tag if field is optional #666

Closed
wants to merge 2 commits into from

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Nov 9, 2022

For #660.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 73.73% // Head: 73.77% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (c5f0517) compared to base (ffa32a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   73.73%   73.77%   +0.04%     
==========================================
  Files         171      171              
  Lines       11995    12012      +17     
==========================================
+ Hits         8844     8862      +18     
  Misses       2682     2682              
+ Partials      469      468       -1     
Impacted Files Coverage Δ
gen/ir/type.go 76.61% <ø> (ø)
gen/ir/field.go 96.29% <100.00%> (+0.98%) ⬆️
gen/templates.go 82.14% <0.00%> (-0.60%) ⬇️
gen/gen_contents.go 72.78% <0.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the fix/omitempty-optionals branch from 2783c65 to c5f0517 Compare November 9, 2022 04:55
@tdakkota tdakkota closed this Nov 9, 2022
@tdakkota tdakkota deleted the fix/omitempty-optionals branch November 9, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant