Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid attribute in faces in Emacs 30: :style none in :box attribute #64

Closed
lpaviets opened this issue Jan 19, 2024 · 4 comments
Closed
Labels

Comments

@lpaviets
Copy link

As said in the title, the :style argument of the :box attribute in faces is no longer valid in recent Emacs versions.

The following faces are affected:

custom-button
custom-button-mouse
custom-button-pressed
cider-fragile-button-face
cider-stacktrace-promoted-button-face
cider-stacktrace-suppressed-button-face

all defined in the file kaolin-themes-lib.el and never modified elsewhere.

Fix: simply delete the :style 'none pair in those 6 faces definitions, or replace it by :style nil which is equivalent.

See also the same problem in Doom Themes.

ogdenwebb added a commit that referenced this issue Jan 25, 2024
@ogdenwebb
Copy link
Owner

Hello, thanks for reporting this issue. Should be fixed now.

@ogdenwebb ogdenwebb added the bug label Jan 26, 2024
@qookei
Copy link

qookei commented Feb 17, 2024

Could you make a new release including the fix for this? It'd be preferable to not package a specific commit in the Gentoo repos.

@ogdenwebb
Copy link
Owner

@qookei I've published a new release with that fix. Besides thank you for maintaining a Gentoo package. 👍

Guess I can close this issue now :)

@qookei
Copy link

qookei commented Feb 17, 2024

Thank you very much! I've just submitted a PR updating the Gentoo package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants