Skip to content

Commit

Permalink
Merge bitcoin#22447: test: whitelist rpc_rawtransaction peers to spee…
Browse files Browse the repository at this point in the history
…d up tests

a3d6ec5 test: move rpc_rawtransaction tests to < 30s group (Jon Atack)
5a1ed96 test: whitelist rpc_rawtransaction peers to speed up tests (Jon Atack)

Pull request description:

  Speed up the somewhat slow `rpc_rawtransaction.py` test by more than 3x (from 45-55 seconds to 15 seconds on a laptop running 2 x 2.5GHz).

ACKs for top commit:
  mjdietzx:
    ACK a3d6ec5
  kristapsk:
    ACK a3d6ec5
  theStack:
    ACK a3d6ec5 🐎
  brunoerg:
    tACK a3d6ec5

Tree-SHA512: f1d105594c9b5b257a7096b631a6fa5aeb50e330a351f75c2d6ffa7dd73abdb6e1f596a78c16d204a9bac3fe506e0519f9ad96bb8477ab6424c8e18125ccb659
  • Loading branch information
fanquake authored and knst committed Sep 25, 2024
1 parent b609514 commit f0c62d5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions test/functional/rpc_rawtransaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ def set_test_params(self):
["-txindex"],
["-txindex"],
]
# whitelist all peers to speed up tx relay / mempool sync
for args in self.extra_args:
args.append("[email protected]")

self.supports_cli = False

def skip_test_if_missing_module(self):
Expand Down
4 changes: 2 additions & 2 deletions test/functional/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@
'wallet_abandonconflict.py --legacy-wallet',
'wallet_abandonconflict.py --descriptors',
'feature_csv_activation.py',
'rpc_rawtransaction.py --legacy-wallet',
'rpc_rawtransaction.py --descriptors',
'feature_reindex.py',
'feature_abortnode.py',
# vv Tests less than 30s vv
Expand Down Expand Up @@ -196,6 +194,8 @@
'feature_proxy.py',
'rpc_signrawtransaction.py --legacy-wallet',
'rpc_signrawtransaction.py --descriptors',
'rpc_rawtransaction.py --legacy-wallet',
'rpc_rawtransaction.py --descriptors',
'p2p_addrv2_relay.py',
'wallet_groups.py --legacy-wallet',
'wallet_groups.py --descriptors',
Expand Down

0 comments on commit f0c62d5

Please sign in to comment.