swapped "is" for "==" in literal comparison

update lint-python.sh to include check F632
ogabrielides · Nov 9, 2020 · b6121ed · b6121ed
1 parent 7e37329
commit b6121ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/contrib/devtools/security-check.py b/contrib/devtools/security-check.py
@@ -62,7 +62,7 @@ def get_ELF_program_headers(executable):
                     splitline = [x.strip() for x in line.split()]
                     flags = splitline[ofs_flags]
                     # check for 'R', ' E'
-                    if splitline[ofs_flags + 1] is 'E':
+                    if splitline[ofs_flags + 1] == 'E':
                         flags += ' E'
                     headers.append((typ, flags, []))
             count += 1

diff --git a/test/lint/lint-python.sh b/test/lint/lint-python.sh
@@ -55,6 +55,7 @@ enabled=(
     F621 # too many expressions in an assignment with star-unpacking
     F622 # two or more starred expressions in an assignment (a, *b, *c = d)
     F631 # assertion test is a tuple, which are always True
+    F632 # use ==/!= to compare str, bytes, and int literals
     F701 # a break statement outside of a while or for loop
     F702 # a continue statement outside of a while or for loop
     F703 # a continue statement in a finally block in a loop