v1.19.1 #9747
Merged
v1.19.1 #9747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-up to commit e5a70c2. There is another error path that the lock need to be released. Signed-off-by: Jianxin Xiong <[email protected]> (cherry picked from commit 826cffb)
Signed-off-by: Franz Pöschel <[email protected]> (cherry picked from commit 22c9d04)
All write accesses to `wait->signal` are protected by the lock. The read access should be protected, too. Signed-off-by: Jianxin Xiong <[email protected]> (cherry picked from commit e16f28a)
Sock variable handle goes out of scope and leaks the handle. This cleans it up properly. Signed-off-by: Zach Dworkin <[email protected]> (cherry picked from commit e6bc224)
Signed-off-by: Jianxin Xiong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CI only. Don't merge. Will be pushed directly.