Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Add coverity builds to Travis #5954

Merged
merged 1 commit into from
May 19, 2020
Merged

travis: Add coverity builds to Travis #5954

merged 1 commit into from
May 19, 2020

Conversation

rajachan
Copy link
Member

Signed-off-by: Raghu Raja [email protected]

@rajachan rajachan requested a review from shefty May 19, 2020 16:57
@rajachan
Copy link
Member Author

This might just do it. Will check coverity and see if the reports show up.

@shefty
Copy link
Member

shefty commented May 19, 2020

I've tried changes like this and have never gotten them to work. That doesn't mean I wasn't doing anything wrong. Do you know if the patch needs to be merged into master prior to coverity running, or if it would run on this PR?

@rajachan
Copy link
Member Author

Do you know if the patch needs to be merged into master prior to coverity running, or if it would run on this PR?

From what I can tell, we'd have to merge it. I did get to trigger my personal coverity project with my fork and this change, but the secrets mismatched so I couldn't do much with it. If we merge and still don't see the reports, we can ditch the Travis part and submit builds from a build server.

@shefty shefty merged commit 72dd30a into ofiwg:master May 19, 2020
@shefty
Copy link
Member

shefty commented May 19, 2020

Let's see if this works -- thanks

@rajachan
Copy link
Member Author

Looks like the build triggered, but I screwed up and missed the notification email field thinking that was optional:

�[0Kcoverity_scan:start
$ export PROJECT_NAME=ofiwg/libfabric
�[33;1mCoverity Scan analysis selected for branch master.�[0m
�[33;1mCoverity Scan analysis authorized per quota.�[0m
travis_fold:start:build_coverity
�[0Ktravis_time:start:18975aff
�[0K$ curl -s https://scan.coverity.com/scripts/travisci_build_coverity_scan.sh | COVERITY_SCAN_PROJECT_NAME="$PROJECT_NAME" COVERITY_SCAN_NOTIFICATION_EMAIL="${COVERITY_SCAN_NOTIFICATION_EMAIL:-}" COVERITY_SCAN_BUILD_COMMAND="${COVERITY_SCAN_BUILD_COMMAND:-make -j2}" COVERITY_SCAN_BUILD_COMMAND_PREPEND="${COVERITY_SCAN_BUILD_COMMAND_PREPEND:-./autogen.sh; ./configure}" COVERITY_SCAN_BRANCH_PATTERN=${COVERITY_SCAN_BRANCH_PATTERN:-master} bash
�[33;1mNote: COVERITY_SCAN_PROJECT_NAME and COVERITY_SCAN_TOKEN are available on Project Settings page on scan.coverity.com�[0m
ERROR: COVERITY_SCAN_NOTIFICATION_EMAIL must be set
travis_time:end:18975aff:start=1589912834626653744,finish=1589912835217308571,duration=590654827,event=script
�[0Ktravis_fold:end:build_coverity
�[0Kcoverity_scan:end

Which email should I set for that?

@shefty
Copy link
Member

shefty commented May 19, 2020

Can we set more than one email? If so, then I'm okay adding personal emails (like mine) there. If not, maybe the ofiwg mail list, until we can setup some alternative? Though I guess even in the latter case, I'm okay using my email while we try to setup a generic one with the OFA.

rajachan added a commit to rajachan/libfabric that referenced this pull request May 21, 2020
Sending notifications to Sean, per discussion in
ofiwg#5954. If the builds work after
this, we can think about setting up a generic list with OFA.

Signed-off-by: Raghu Raja <[email protected]>
@rajachan
Copy link
Member Author

Looks like that worked 😅 https://scan.coverity.com/projects/ofiwg-libfabric

@shefty
Copy link
Member

shefty commented May 26, 2020

Yep -thanks! And for a 2-year hiatus, the number of new defects isn't too bad.

JuliaRS pushed a commit to JuliaRS/libfabric that referenced this pull request Feb 11, 2021
Sending notifications to Sean, per discussion in
ofiwg#5954. If the builds work after
this, we can think about setting up a generic list with OFA.

Signed-off-by: Raghu Raja <[email protected]>
@rajachan rajachan deleted the master branch June 15, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants