tcp provider: Early remove ep from polling after shutdown #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the polling thread in our applicatioon is spinning for some time after calling fi_shutdown(). Reason is that we only call fi_close() after all references to our internal connection handling are dropped and that can be much later than the call of fi_close() and the FI_SHUTDOWN event handling. Our polling thread then started to spin without ever going to sleep. The solution here is to remove the endpoint from polling after the TCPX_EP_SHUTDOWN flag is set and only after another round of polling in tcpx_progress() - similar to what the socket provider does. Change-Id: I66ea20bf344ae8f74a67532657d0e1d199638391 Signed-off-by: Bernd Schubert <[email protected]>
|
This is the updated patch. I'm sorry again for the last patch, I hadn't noticed that master had heavily changed when the merge conflict was auto-resolved. It now also uses the existing ep->cm_state. |
|
thanks |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the polling thread in our applicatioon
is spinning for some time after calling fi_shutdown().
Reason is that we only call fi_close() after all references
to our internal connection handling are dropped and that
can be much later than the call of fi_close() and the
FI_SHUTDOWN event handling. Our polling thread then
started to spin without ever going to sleep.
The solution here is to remove the endpoint from polling
after the TCPX_EP_SHUTDOWN flag is set and only after
another round of polling in tcpx_progress() - similar to
what the socket provider does.
Signed-off-by: Bernd Schubert [email protected]