prov/efa: fixing bug with reporting cq errors and fixing logic #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancejic
requested review from
rajachan,
dipti-kothari,
rwespetal,
shijin-aws,
wckzhang,
wzamazon,
zhngaj and
a team
and removed request for
rajachan,
rwespetal,
dipti-kothari,
wckzhang,
zhngaj,
wzamazon and
shijin-aws
|
bot:aws:retest |
|
bot:as:retest |
|
bot:aws:retest |
1 similar comment
|
bot:aws:retest |
rwespetal
reviewed
Mar 3, 2020
prov/efa/src/efa_ep.c
Outdated
|
|
||
| err = efa_cq_readerr(&cq->cq_fid, &cq_err_entry, flags); | ||
| if (OFI_UNLIKELY(err < 0)) { | ||
| EFA_WARN(FI_LOG_CQ, "unable to read error entry errno: %ld\n", ret); |
this patch fixed a bug where efa_ep_progress_internal would check for FI_EAVAIL instead of -FI_EAVAIL and fixed some of the logic surrounding error detection on the function. EQ entries are now filled when the cq cannot be read or when error entries cannot be read. Signed-off-by: Nikola Dancejic <[email protected]>
rwespetal
approved these changes
Mar 3, 2020
wzamazon
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch fixed a bug where efa_ep_progress_internal would check for
FI_EAVAIL instead of -FI_EAVAIL and fixed some of the logic surrounding error
detection on the function. EQ entries are now filled when the cq cannot be
read or when error entries cannot be read.
Signed-off-by: Nikola Dancejic [email protected]