Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/sockets: log unsupported address format #3024

Merged
merged 1 commit into from
Jun 5, 2017
Merged

prov/sockets: log unsupported address format #3024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions prov/sockets/src/sock_fabric.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ int sock_verify_info(uint32_t version, struct fi_info *hints)
case FI_SOCKADDR_IN:
break;
default:
SOCK_LOG_DBG("Unsupported address format\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set this to INFO, rather than debug, so that the message is available in release builds.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shefty, there is no macro SOCK_LOG_INFO, so SOCK_LOG_DBG is used everywhere in sockets provider.
May be you want to create such macro and replace each DBG with INFO?

return -FI_ENODATA;
}

Expand Down