fabtests: corrected flags argument type in ft_sendmsg/ft_recvmsg #10643
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions fixed fabtests send and recv functions to use flags argument type as uint64_t instead of int as the underlying fi calls use uint64_t. removed declaration of unused function ft_writemsg from shared.h Also fixed functions calling ft_sendmsg and ft_recvmsg touse uint64_t for flags Signed-off-by: Nikhil Nanal <[email protected]>
nikhilnanal
force-pushed
the
ftmsgflagtype
branch
from
a61b540 to
24b0eba
Compare
aingerson
reviewed
Dec 17, 2024
| @@ -425,7 +425,7 @@ static int rma_bw_rx_comp() | |||
| return ft_tx(ep, remote_fi_addr, FT_RMA_SYNC_MSG_BYTES, &tx_ctx); | |||
| } | |||
|
|
|||
| static int set_fi_more_flag(int i, int j, int flags) | |||
| static int set_fi_more_flag(int i, int j, uint64_t flags) | |||
There was a problem hiding this comment.
the flags are returned here - should be uint64_t as well
nikhilnanal
force-pushed
the
ftmsgflagtype
branch
from
24b0eba to
6dccaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed fabtests send and recv functions to use flags argument type as uint64_t instead of int as the underlying fi calls use uint64_t. removed declaration of unused function ft_writemsg from shared.h