[v1.22.x] prov/efa: Fix the read_bad_recv_status unit test

When device supports unsolicited write, efadv_wc_is_unsolicited is called in the error path of IBV_WC_RECV as well, but we failed to setup its mock in the unit test, it will cause a segfault inside the rdma-core function when we don't really have a cqe, which is what the current unit test does. This patch fixes this bug. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit 628dfa7)
ofiwg · Nov 20, 2024 · d701175 · d701175
1 parent 6ea25b0
commit d701175
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/prov/efa/test/efa_unit_test_cq.c b/prov/efa/test/efa_unit_test_cq.c
@@ -319,6 +319,14 @@ void test_ibv_cq_ex_read_bad_recv_status(struct efa_resource **state)
 	 */
 	efa_rdm_cq->ibv_cq.ibv_cq_ex->wr_id = (uintptr_t)pkt_entry;
 	efa_rdm_cq->ibv_cq.ibv_cq_ex->status = IBV_WC_GENERAL_ERR;
+
+#if HAVE_CAPS_UNSOLICITED_WRITE_RECV
+	if (efa_rdm_use_unsolicited_write_recv()) {
+		efadv_cq_from_ibv_cq_ex(efa_rdm_cq->ibv_cq.ibv_cq_ex)->wc_is_unsolicited = &efa_mock_efadv_wc_is_unsolicited;
+		will_return(efa_mock_efadv_wc_is_unsolicited, false);
+	}
+#endif
+
 	ret = fi_cq_read(resource->cq, &cq_entry, 1);
 	assert_int_equal(ret, -FI_EAGAIN);