Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document workflow and policies on Wiki #9

Closed
sungeunchoi opened this issue Feb 2, 2015 · 3 comments
Closed

Document workflow and policies on Wiki #9

sungeunchoi opened this issue Feb 2, 2015 · 3 comments
Assignees
@sungeunchoi

Comments

@sungeunchoi
Copy link

No description provided.

@sungeunchoi sungeunchoi self-assigned this Feb 2, 2015
@bturrubiates
Copy link

Definitely things to add to the workflow policy:

  • The linux style guide script. Link to your script and provide instructions for setting up the hook.
  • Recommend the pro git book. It is one of the best books for learning git and is also free to read online.

I think it'd be helpful for us to start an issue heavy workflow. Anytime that a fix/feature is going to be added it must contain an issue. The closes tag can then be used in the pull request to make sure that it is automatically resolved.

I said most of this in the conference call, but I figure I should write it out here before forgetting. 👍

@sungeunchoi Are you still going to take this issue?

@sungeunchoi
Copy link
Author

Yup. I've got this.

@bturrubiates
Copy link

👍

ztiffany pushed a commit to ztiffany/fabtests-cray that referenced this issue Apr 2, 2015
Add multi-domain unit test.
219c832 
Fixes ofi-cray/libfabric-cray#9.

Signed-off-by: Zach Tiffany <[email protected]>
ztiffany pushed a commit to ztiffany/fabtests-cray that referenced this issue Apr 3, 2015
Add multi-domain unit test.
08a92d2 
Fixes ofi-cray/libfabric-cray#9.

Signed-off-by: Zach Tiffany <[email protected]>
ztiffany pushed a commit to ztiffany/fabtests-cray that referenced this issue Apr 6, 2015
Add multi-domain unit test.
5ce50a2 
Fixes ofi-cray/libfabric-cray#9.

Signed-off-by: Zach Tiffany <[email protected]>
@hppritcha hppritcha mentioned this issue Jun 29, 2015
Closed
@tenbrugg tenbrugg mentioned this issue Jun 27, 2016
Open
@epaulson10 epaulson10 mentioned this issue Feb 10, 2017
Closed
@jshimek jshimek mentioned this issue Apr 25, 2017
Closed
jswaro pushed a commit to jswaro/libfabric that referenced this issue Jun 2, 2021
@Honggang-LI
src/common.c: fix a stack-buffer-overflow issue
5343004 
ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff4c61e7e0 at pc 0x14f2cb7ae0b9 bp 0x7fff4c61e650 sp 0x7fff4c61ddd8
WRITE of size 17 at 0x7fff4c61e7e0 thread T0
    #0 0x14f2cb7ae0b8  (/lib64/libasan.so.5+0xb40b8)
    #1 0x14f2cb7aedd2 in vsscanf (/lib64/libasan.so.5+0xb4dd2)
    #2 0x14f2cb7aeede in __interceptor_sscanf (/lib64/libasan.so.5+0xb4ede)
    #3 0x14f2cb230766 in ofi_addr_format src/common.c:401
    #4 0x14f2cb233238 in ofi_str_toaddr src/common.c:780
    #5 0x14f2cb314332 in vrb_handle_ib_ud_addr prov/verbs/src/verbs_info.c:1670
    #6 0x14f2cb314332 in vrb_get_match_infos prov/verbs/src/verbs_info.c:1787
    #7 0x14f2cb314332 in vrb_getinfo prov/verbs/src/verbs_info.c:1841
    #8 0x14f2cb21fc28 in fi_getinfo_ src/fabric.c:1010
    ofi-cray#9 0x14f2cb25fcc0 in ofi_get_core_info prov/util/src/util_attr.c:298
    ofi-cray#10 0x14f2cb269b20 in ofix_getinfo prov/util/src/util_attr.c:321
    ofi-cray#11 0x14f2cb3e29fd in rxd_getinfo prov/rxd/src/rxd_init.c:122
    ofi-cray#12 0x14f2cb21fc28 in fi_getinfo_ src/fabric.c:1010
    ofi-cray#13 0x407150 in ft_getinfo common/shared.c:794
    ofi-cray#14 0x414917 in ft_init_fabric common/shared.c:1042
    ofi-cray#15 0x402f40 in run functional/bw.c:155
    ofi-cray#16 0x402f40 in main functional/bw.c:252
    ofi-cray#17 0x14f2ca1b28e2 in __libc_start_main (/lib64/libc.so.6+0x238e2)
    ofi-cray#18 0x401d1d in _start (/root/libfabric/fabtests/functional/fi_bw+0x401d1d)

Address 0x7fff4c61e7e0 is located in stack of thread T0 at offset 48 in frame
    #0 0x14f2cb2306f3 in ofi_addr_format src/common.c:397

  This frame has 1 object(s):
    [32, 48) 'fmt' <== Memory access at offset 48 overflows this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow (/lib64/libasan.so.5+0xb40b8)
Shadow bytes around the buggy address:
  0x1000698bbca0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x1000698bbcb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x1000698bbcc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x1000698bbcd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x1000698bbce0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x1000698bbcf0: 00 00 00 00 00 00 f1 f1 f1 f1 00 00[f2]f2 f3 f3
  0x1000698bbd00: f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1
  0x1000698bbd10: f1 f1 00 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2
  0x1000698bbd20: f2 f2 00 f2 f2 f2 f2 f2 f2 f2 00 f2 f2 f2 f2 f2
  0x1000698bbd30: f2 f2 00 00 00 00 00 06 f2 f2 f2 f2 f2 f2 00 00
  0x1000698bbd40: 00 00 00 06 f2 f2 f2 f2 f2 f2 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb

Fixes: 5d31276 ("common: Redo address string conversions")
Signed-off-by: Honggang Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungeunchoi sungeunchoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bturrubiates @sungeunchoi