-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only validate unfinished cache runs #2046
Merged
ppigazzini
merged 1 commit into
official-stockfish:master
from
vdbergh:validate_unfinished
Jun 1, 2024
Merged
Only validate unfinished cache runs #2046
ppigazzini
merged 1 commit into
official-stockfish:master
from
vdbergh:validate_unfinished
Jun 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vondele
reviewed
Jun 1, 2024
So far so good (I loaded many old runs in my browser). Jun 01 06:35:13 tests.stockfishchess.org systemd[1]: Stopping Fishtest Server port 6543...
Jun 01 06:35:13 tests.stockfishchess.org pserve[12453]: flush
Jun 01 06:35:14 tests.stockfishchess.org pserve[12453]: ........................done
Jun 01 06:35:16 tests.stockfishchess.org systemd[1]: Stopped Fishtest Server port 6543.
Jun 01 06:35:53 tests.stockfishchess.org systemd[1]: Started Fishtest Server port 6543.
Jun 01 06:35:56 tests.stockfishchess.org pserve[15218]: Starting server in PID 15218.
Jun 01 06:36:00 tests.stockfishchess.org pserve[15218]: Request_task: no useful cached runs left
Jun 01 06:36:00 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:37:01 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:38:05 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:38:47 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665ab125062b2c3cf814ff7c...
Jun 01 06:39:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:40:18 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:41:24 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:41:53 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aad3f062b2c3cf814ff66...
Jun 01 06:42:07 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:43:12 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:44:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:44:56 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aab2d062b2c3cf814ff58...
Jun 01 06:45:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:46:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:47:16 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:47:48 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aad3f062b2c3cf814ff66...
Jun 01 06:48:16 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:49:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:50:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:50:40 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665a9821062b2c3cf814fed8...
Jun 01 06:50:41 tests.stockfishchess.org pserve[15218]: dead task: run: https://tests.stockfishchess.org/tests/view/665a9821062b2c3cf814fed8 task_id: 745 worker: nikkorelox1234-3cores-71adf505-965a
Jun 01 06:51:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:52:19 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:53:20 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:53:46 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665ab622062b2c3cf814ff94...
Jun 01 06:54:20 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:55:28 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:56:33 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue |
Old runs often do not validate due to the existence race conditions in the past.
d35f9dc
to
2d06e6b
Compare
ppigazzini
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on PROD
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old runs often do not validate due to the existence race conditions in the past.