Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only validate unfinished cache runs #2046

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

vdbergh
Copy link
Contributor

@vdbergh vdbergh commented Jun 1, 2024

Old runs often do not validate due to the existence race conditions in the past.

server/fishtest/rundb.py Outdated Show resolved Hide resolved
@ppigazzini
Copy link
Collaborator

So far so good (I loaded many old runs in my browser).

Jun 01 06:35:13 tests.stockfishchess.org systemd[1]: Stopping Fishtest Server port 6543...
Jun 01 06:35:13 tests.stockfishchess.org pserve[12453]: flush
Jun 01 06:35:14 tests.stockfishchess.org pserve[12453]: ........................done
Jun 01 06:35:16 tests.stockfishchess.org systemd[1]: Stopped Fishtest Server port 6543.
Jun 01 06:35:53 tests.stockfishchess.org systemd[1]: Started Fishtest Server port 6543.
Jun 01 06:35:56 tests.stockfishchess.org pserve[15218]: Starting server in PID 15218.
Jun 01 06:36:00 tests.stockfishchess.org pserve[15218]: Request_task: no useful cached runs left
Jun 01 06:36:00 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:37:01 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:38:05 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:38:47 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665ab125062b2c3cf814ff7c...
Jun 01 06:39:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:40:18 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:41:24 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:41:53 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aad3f062b2c3cf814ff66...
Jun 01 06:42:07 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:43:12 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:44:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:44:56 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aab2d062b2c3cf814ff58...
Jun 01 06:45:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:46:15 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:47:16 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:47:48 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665aad3f062b2c3cf814ff66...
Jun 01 06:48:16 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:49:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:50:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:50:40 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665a9821062b2c3cf814fed8...
Jun 01 06:50:41 tests.stockfishchess.org pserve[15218]: dead task: run: https://tests.stockfishchess.org/tests/view/665a9821062b2c3cf814fed8 task_id: 745 worker: nikkorelox1234-3cores-71adf505-965a
Jun 01 06:51:17 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:52:19 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:53:20 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:53:46 tests.stockfishchess.org pserve[15218]: Validate_random_run: validated aggregated data in cache run 665ab622062b2c3cf814ff94...
Jun 01 06:54:20 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:55:28 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue
Jun 01 06:56:33 tests.stockfishchess.org pserve[15218]: Request_task: refresh queue

Old runs often do not validate due to the existence race
conditions in the past.
@vdbergh vdbergh force-pushed the validate_unfinished branch from d35f9dc to 2d06e6b Compare June 1, 2024 09:54
Copy link
Collaborator

@ppigazzini ppigazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on PROD

@ppigazzini ppigazzini merged commit fc6b306 into official-stockfish:master Jun 1, 2024
19 checks passed
@ppigazzini ppigazzini mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement server server side changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants