Presumably a fix for deadlock (see #2041). #2042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
We use a separate lock to update aggregates. To this end we extend self.active_run_lock() with an optional argument "name" to be able to have different locks associated with the same run_id.
|
If #2029 would be merged then a better fix would be to do the scavenging of dead tasks as a separate scheduled task (as mentioned in #2029 (comment)). This does not need the |
|
I have drafted this since #2029 is now being tested. |
|
I am closing this now in view of the merging of #2029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a separate lock to update aggregates. To this end we extend self.active_run_lock() with an optional argument
nameto be able to have different locks associated with the samerun_id.