Replace deprecated distutils package
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppigazzini
added
enhancement
worker update
The package `distutils` is deprecated since python 3.10 and it is scheduled to be removed with python 3.12, see: https://docs.python.org/3.12/whatsnew/3.12.html python/cpython#92584 `shutil.copytree()` is able to copy the source directory tree to an existing destination directory only from python 3.8 (parameter `dirs_exist_ok=True`), for python < 3.8 still use `distutils.dir_util.copy_tree()` While here: - create in a safe way the temporary directory used for the update - deal with possible download problems Raise worker version to 214 (also server side)
ppigazzini
force-pushed
the
deprecated_distutils
branch
from
622c1c7 to
5410bb0
Compare
|
With python 3.12.0rc1 master doesn't work: $ python3 worker.py
Traceback (most recent call last):
File "/home/usrft/fishtest/worker/worker.py", line 52, in <module>
from updater import update
File "/home/usrft/fishtest/worker/updater.py", line 5, in <module>
from distutils.dir_util import copy_tree
ModuleNotFoundError: No module named 'distutils' |
|
PR tested working with linux worker (python: 3.6.8, 3.8.0, 3.11.5, 3.12.0rc1) and windows worker (python: 3.11.5). |
|
Triggered the workers update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
distutilsis deprecated since python 3.10 and it is scheduled to be removed with python 3.12, see: https://docs.python.org/3.12/whatsnew/3.12.htmlpython/cpython#92584
shutil.copytree()is able to copy the source directory tree to an existing destination directory only from python 3.8 (parameterdirs_exist_ok=True), for python < 3.8 still usedistutils.dir_util.copy_tree()While here:
Raise worker version to 214 (also server side)