Refactor reduction rules. #5871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rule and the scaling becomes more clear. No functional change
|
@vondele @Disservin This is a proposal to concentrate all the ttPv/PV reduction stuff at one place were its clear that its a scaler. Perhaps we can merge this in another rewrite or collection of changing comments or formatting if the idea finds approval. |
|
i don't mind makes it easier to see which parts are scalers when reviewing patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its unlucky that some ttPv modification in reductions are not united in on rule. So split up the ttPv part int cut node rule and also includes the simply PV node rule.
No functional change