Simplify slider_blockers method #4753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2023 14:31
Now that classical evaluation was removed, we can adopt this method. Use color as template. no functional change bench: 1493904
Now that classical evaluation was removed, we can adopt this method to the purposes of set_check_info method. no functional change bench: 1493904
|
N.B.: a templated version of simplified slider_blockers is being tested here at https://tests.stockfishchess.org/tests/view/64de132587ff9c9f7a9351f6 but I doubts its a good idea to make this templated by color. |
Improve comment no functional change bench: 1493904
|
might be good to test this patch as is on fishtest, to be sure? (just STC is fine) |
|
I suggest renaming it to |
Now that classical evaluation was removed, we can adopt this method to the purposes of set_check_info method. no functional change bench: 1426295
Sopel97
reviewed
Aug 24, 2023
Improve comment no functional change
https://tests.stockfishchess.org/tests/view/64e70b899009777747557b43 |
|
merged via 1f7ff84, thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that classical evaluation was removed, we can adopt this method to the needs of set_check_info.
no functional change