Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebel loadout fixes #3458

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Rebel loadout fixes #3458

merged 1 commit into from
Dec 13, 2024

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Dec 9, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

  • Changed custom loadout UI to work with temporary copy. Safer, and fixes serious bug with Reset All button.
  • Added case for static crew (eg mortar team units) and fixed optics typo in fallback case.
  • Disabled optics UI control so that players are less likely to expect it to do something.
  • Fixed casing on button to open custom loadouts UI.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22
Rebel loadout fixes:
8514f3d 
- Changed custom loadout UI to work with temporary copy. Safer, and fixes bug with Reset All button.
- Added case for static crew (eg mortar team units) and fixed optics typo in fallback case.
- Disabled optics control so that players are less likely to expect it to do something.
- Fixed casing on button to open custom loadouts UI.
@jaj22 jaj22 added Bug Something isn't working Review pending labels Dec 9, 2024
@jaj22 jaj22 added this to the 3.8.0 milestone Dec 9, 2024
Play3rgg
Play3rgg approved these changes Dec 10, 2024
View reviewed changes
Copy link

@Play3rgg Play3rgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the optic choice but better this than there being a non-function option.
LGTM

ante185
ante185 approved these changes Dec 11, 2024
View reviewed changes
Copy link

@ante185 ante185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressed all the buttons and nothing broke, looks good to me

@Bob-Murphy Bob-Murphy merged commit 0157d28 into official-antistasi-community:unstable Dec 13, 2024
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ante185 ante185 ante185 approved these changes

@Play3rgg Play3rgg Play3rgg approved these changes

Assignees
No one assigned
Labels
Added to changelog Added to changelog Bug Something isn't working Ready for merge
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jaj22 @Play3rgg @ante185 @Bob-Murphy