Garage Sell Button #3237
Garage Sell Button #3237
Conversation
|
Mostly copied from #general-dev-stuff: The main thing you're missing is that the internal garage code shouldn't be calling Antistasi functions (eg resources, vehiclePrice) or using Antistasi vars (eg. theBoss) directly. Instead that should go through stub functions in public.inc, and selling ability shouldn't be assumed, because the garage might be used as a separate mod where money isn't a valid concept. You'll need a separate commander check function from isCmdClient because unlocking and selling permissions are somewhat different. Should rename isCmdClient to canLock or something similarly specific. |
jaj22
added
Change requested
Tiny-DM
added
Review pending
and removed
Change requested
|
Is editing garage code legal? Or you asked Hakon for it? |
Asked Hakon, yes. |
Co-authored-by: Jouni Järvinen <[email protected]>
| private _disp = findDisplay HR_GRG_IDD_Garage; | ||
|
|
||
| { | ||
| _ctrl = _disp displayCtrl _x; | ||
| _ctrl ctrlEnable false; | ||
| _ctrl ctrlShow false; | ||
| } forEach [HR_GRG_IDC_ExtraMounts,HR_GRG_IDC_ExtraTexture,HR_GRG_IDC_ExtraAnim,HR_GRG_IDC_ExtraPylonsContainer]; |
There was a problem hiding this comment.
This doesn't do anything and can be stripped out. It's only present in onLoad because these controls all start enabled, and switchExtrasMenu only disables the currently-enabled control for some reason.
|
|
||
|
|
||
| Return Value: | ||
| <nil> |
There was a problem hiding this comment.
| <nil> | |
| <NIL> |
I missed this one somehow.
What type of PR is this.
What have you changed and why?
Information: Added an integrated sell button to the garage GUI.
Checks for commander status and locked status before selling
Please specify which Issue this PR Resolves.
closes #2377
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Mostly needs testing to see if everything works in a multiplayer setting. None of the core functionality was changed too much, so it should be fine but still needs to be tested
Notes: