Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla UK/NATO faction #3177

Merged
merged 8 commits into from
Mar 30, 2024
Merged

Vanilla UK/NATO faction #3177

merged 8 commits into from
Mar 30, 2024

Conversation

ante185
Copy link

@ante185 ante185 commented Mar 19, 2024 •
edited
Loading

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Adds arid and green templates built from APEX that feature what the armaverse british forces would look like in 2035

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

Notes:

@ante185 ante185 marked this pull request as ready for review March 19, 2024 22:11
@ante185 ante185 added Change A change to existing functionality Review pending Templates Items related to templates labels Mar 19, 2024
@ante185 ante185 requested a review from Tiny-DM March 28, 2024 15:51
@Bob-Murphy Bob-Murphy added this to the 3.5.2 - Reaction Forces milestone Mar 30, 2024
Tiny-DM
Tiny-DM requested changes Mar 30, 2024
View reviewed changes
Copy link

@Tiny-DM Tiny-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to assign a gun to a non-existent loadout, otherwise looks good

A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_UK_Arid.sqf Outdated Show resolved Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_UK_Tropical.sqf Outdated Show resolved Hide resolved
@ante185 ante185 requested a review from Tiny-DM March 30, 2024 20:24
Tiny-DM
Tiny-DM approved these changes Mar 30, 2024
View reviewed changes
Copy link

@Tiny-DM Tiny-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, RPT is clean and soldiers have proper gear for all 3

@Bob-Murphy Bob-Murphy merged commit 3d575f6 into official-antistasi-community:unstable Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tiny-DM Tiny-DM Tiny-DM approved these changes

Assignees
No one assigned
Labels
Change A change to existing functionality Ready for merge Templates Items related to templates
Projects
None yet
Milestone
3.5.2 - Reaction Forces
Development

Successfully merging this pull request may close these issues.
3 participants
@ante185 @Tiny-DM @Bob-Murphy