Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous logs fix for garage #3090

Merged

Conversation

Tiny-DM
Copy link

@Tiny-DM Tiny-DM commented Dec 11, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Changed the line to update the garage interface to only work when there's someone in the garage interface, removing 2 startup errors and 1 error every time someone garaged a vehicle. All errors purely present in the logs with no gameplay impact

Please specify which Issue this PR Resolves.

closes this discord comment from John

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

Copy link

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to check a nil against anything will break, so it's 1 of the cases where lazy eval is mandatory.

A3A/addons/garage/Public/fn_addVehicle.sqf Outdated Show resolved Hide resolved
A3A/addons/garage/Public/fn_addVehiclesByClass.sqf Outdated Show resolved Hide resolved
@jaj22
Copy link

jaj22 commented Dec 12, 2023

I'd just pull the isNils personally. If HR_GRG_Users is nil at that point then the rest of the code isn't going to work either. Having the isNil in there makes it look like it's a valid possibility.

Copy link

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather it didn't have the isNil statements but it'll work.

@Tiny-DM
Copy link
Author

Tiny-DM commented Dec 12, 2023

You guys are too picky :P That's my excuse for not writing it properly the first time. Regardless, the isNil's have been pulled for clarity.

@rautamiekka
Copy link

I'd just pull the isNils personally. If HR_GRG_Users is nil at that point then the rest of the code isn't going to work either. Having the isNil in there makes it look like it's a valid possibility.

Good point.

@Bob-Murphy Bob-Murphy added this to the 3.5 milestone Dec 23, 2023
@Bob-Murphy Bob-Murphy merged commit f1692c5 into official-antistasi-community:unstable Dec 23, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants