-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous logs fix for garage #3090
Miscellaneous logs fix for garage #3090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to check a nil against anything will break, so it's 1 of the cases where lazy eval is mandatory.
I'd just pull the isNils personally. If HR_GRG_Users is nil at that point then the rest of the code isn't going to work either. Having the isNil in there makes it look like it's a valid possibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would rather it didn't have the isNil statements but it'll work.
You guys are too picky :P That's my excuse for not writing it properly the first time. Regardless, the isNil's have been pulled for clarity. |
Good point. |
What type of PR is this.
What have you changed and why?
Information:
Changed the line to update the garage interface to only work when there's someone in the garage interface, removing 2 startup errors and 1 error every time someone garaged a vehicle. All errors purely present in the logs with no gameplay impact
Please specify which Issue this PR Resolves.
closes this discord comment from John
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?