Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some real and theoretical revive issues #3059

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Fix some real and theoretical revive issues #3059

merged 1 commit into from
Nov 25, 2023

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Nov 22, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

  • Fixed a bug where players could have revive permanently disabled if they were killed by damage while downed.
  • Changed downed damage lockout to 0.2 seconds rather than one frame. This is to handle a theoretical case where the server might split HandleDamage calls across multiple packets. Not if it happens, but it won't hurt anyway.
  • Remove persistence of the downed damage accumulator. The "starting point" for downed damage used to vary by the revive method, but it incorrectly persisted over respawns, and didn't make a whole lot of sense anyway.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22
Fix some real and theoretical revive issues:
88c3b78 
- Fixed a bug where players could have revive permanently disabled.
- Changed downed damage lockout to 0.2 seconds rather than one frame.
- Remove persistence of downed damage accumulator.
@jaj22 jaj22 added Bug Something isn't working Change A change to existing functionality labels Nov 22, 2023
@jaj22 jaj22 added this to the 3.4.1 milestone Nov 22, 2023
killerswin2
killerswin2 approved these changes Nov 25, 2023
View reviewed changes
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Bob-Murphy Bob-Murphy merged commit 8ab0418 into official-antistasi-community:unstable Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killerswin2 killerswin2 killerswin2 approved these changes

Assignees

@CalebSerafin CalebSerafin

@Bob-Murphy Bob-Murphy

Labels
Bug Something isn't working Change A change to existing functionality Ready for merge
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jaj22 @killerswin2 @CalebSerafin @Bob-Murphy