Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACE fuel state not being correctly set on ungaraging #3053

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Nov 21, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

The ACE fuel cargo state wasn't being correctly set when ungaraging vehicles, because ACE uses the ace_refuel_capacity variable to indicate whether the fuel cargo vars have been initialized, and doesn't set it itself until a player interacts with the vehicle. Hence fuel vehicles were being topped up to capacity when players interacted with them.

Not absolutely sure that this is a good thing to merge, because I don't think there's currently any way to top up fuel cargo other than this bug. Community might not deal well with the fix.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added Bug Something isn't working Info needed Further information is requested. labels Nov 21, 2023
@killerswin2
Copy link

acemod/ACE3#8981 It was merged.

Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged. But hold off for more info.

@killerswin2 killerswin2 added the Don't merge This needs to be touched before being merged label Nov 25, 2023
@jaj22 jaj22 added this to the 3.5 milestone Nov 25, 2023
@jaj22 jaj22 removed Info needed Further information is requested. Don't merge This needs to be touched before being merged labels Nov 25, 2023
@Bob-Murphy
Copy link

@killerswin2 can this be merged now or not?
Please answer and adapt Label if necessary.

@Bob-Murphy Bob-Murphy merged commit e5d4088 into official-antistasi-community:unstable Dec 23, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Bug Something isn't working Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants