Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nato gunship support #2160

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Fix nato gunship support #2160

merged 3 commits into from
Oct 6, 2021

Conversation

wurzel0701
Copy link

@wurzel0701 wurzel0701 commented Oct 5, 2021

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Fixed NATO gunships shooting occupants units
Fixed early exit case not deleting
Readjusted target offset to hit targets better

Please specify which Issue this PR Resolves.

closes none

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Spawn in a random location and call following code

[0, 0,"airport_1", getPos player, "GUNSHIP0"] spawn A3A_fnc_SUP_gunshipRoutineNATO;
server setVariable ["GUNSHIP0_targets", [[[player, 3], 1]]];

Notes:

@wurzel0701 wurzel0701 changed the base branch from master to unstable October 5, 2021 09:33
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Bob-Murphy Bob-Murphy added this to the 2.5.3 milestone Oct 5, 2021
@Bob-Murphy Bob-Murphy merged commit e225b32 into unstable Oct 6, 2021
@Bob-Murphy Bob-Murphy deleted the Fix-Nato-gunship-support branch January 26, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants