Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undercover on setup of ACE explosives #2158

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Remove undercover on setup of ACE explosives #2158

merged 1 commit into from
Oct 4, 2021

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Oct 4, 2021

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Added client event handler to remove undercover status when an ACE explosive is set up (note that this is on trigger setup, not placement).

Please specify which Issue this PR Resolves.

Bob didn't want to publicize the issue.

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added the Change A change to existing functionality label Oct 4, 2021
killerswin2
killerswin2 approved these changes Oct 4, 2021
View reviewed changes
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Bob-Murphy Bob-Murphy added this to the 2.5.3 milestone Oct 4, 2021
@Bob-Murphy Bob-Murphy merged commit 54b7a8b into official-antistasi-community:unstable Oct 4, 2021
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killerswin2 killerswin2 killerswin2 approved these changes

Assignees

@Bob-Murphy Bob-Murphy

Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jaj22 @killerswin2 @Bob-Murphy