Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement type-dependent classes for rebel AIs #1947

Conversation

jaj22
Copy link

@jaj22 jaj22 commented May 24, 2021

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Implemented type-dependent classes for rebel AIs. This makes the unit type icons in the command bar work correctly (medics and engineers now have the appropriate symbol), plus the overlay names no longer all say "riflemen". Petros is now "officer", for example.

Each element of customUnitTypes now has an additional parameter for the unit class to be used for that unit type. These are varied for rebel units only, as we don't much care about the UI for enemy troops.

Also fixed some misnamed loadout -> definition variables, and fixed the incorrect loadout count debug text. Definitions already had an extra parameter of unit traits, so the format apparently changed at some point.

Based on vn-development so that we can get the merge conflicts in early.

I haven't checked the code for civ creation but they seem to work for whatever reason. Enemies should be fine.

Please specify which Issue this PR Resolves.

mentioned in #1914

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Enable command bar and the server difficulty option that gives you information about your troops on mouseover. Recruit all the different rebels and look at them. Also check out Petros. He likes it.

@jaj22 jaj22 added the Enhancement New feature or request label May 24, 2021
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working.
To me the code looks good but I rather wait for a second pair of eyes on that.

@Bob-Murphy Bob-Murphy added this to the 2.4.2 milestone May 25, 2021
@Bob-Murphy Bob-Murphy merged commit e1c56d8 into official-antistasi-community:vn-development May 25, 2021
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants