Skip to content

Commit

Permalink
fixing console error about bad html attribute (apache#10604)
Browse files Browse the repository at this point in the history
  • Loading branch information
rusackas authored and Ofeknielsen committed Oct 5, 2020
1 parent d99bdfd commit 44addd1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion superset-frontend/src/components/Button/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,13 @@ export default function Button(props: ButtonProps) {
<SupersetButton {...buttonProps}>{props.children}</SupersetButton>
);

const whittledProps = { ...buttonProps };
delete whittledProps.dropdownItems;

if (dropdownItems) {
button = (
<div style={BUTTON_WRAPPER_STYLE}>
<SupersetButton {...buttonProps} data-toggle="dropdown">
<SupersetButton {...whittledProps} data-toggle="dropdown">
{props.children}
</SupersetButton>
<ul className="dropdown-menu">
Expand Down

0 comments on commit 44addd1

Please sign in to comment.