Add Selenium headless driver #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Selenium [DEPRECATION] :profile is deprecated. Use Selenium::WebDriver::Firefox::Options#profile= instead." warning
|
Note: The CI failures aren't to do with my code -- looks like there's an issue with dependencies in the CI environment itself. |
|
@xtrasimplicity Thanks for the contribution! If you have a chance to try addressing the CI issue, please feel free, so I'll try to tackle in a few weeks. |
|
Thanks, @ronwsmith. I'll take a look and will submit a new PR for the CI issue. |
|
Scratch that, someone else has come up with a CI fix as part of another PR: #273 :) |
|
Hi @ronwsmith, any updates on this and #273? Thanks! |
|
@xtrasimplicity I'm back! Thanks for your contribution and patience. |
|
Released in v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
selenium_billydriver doesn't appear to support headless mode, and also (though unrelated) throws aSelenium [DEPRECATION] :profile is deprecated. Use Selenium::WebDriver::Firefox::Options#profile= instead.warning.Summary
I've simply refactored the
selenium_billydriver so that we're no longer using the deprecated method of setting a profile, and then added aselenium_headless_billydriver with headless support.