Don't attempt to print backtrace when it's not available (EM event handler) #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causing an exception in EM error handler terminates thread, what in turns makes subsequent specs fail
kowalskey
changed the title
kowalskey
changed the title
|
Released in 1.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Looks like
Exceptions are allowed to not have backtrace availableTrying to
join()on nil terminates puffing billy so I think it's feasible to check whether exception has backtrace before atttempting to print itI had some problems with
puffing-billyterminating because of exception in main_loop thread what caused it to terminate and as a consequence - following tests in suite to fail because proxy has just died so no requests passed through it would receive a response