Make stub requests accessible #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackermans
changed the title
|
@mackermans thanks for the contribution! Can you add the config option to the README and include an example of how/why you'd use this? |
|
@ronwsmith sure thing! I added some documentation to the README and provided example specs. |
|
It looks like PhantomJS 1.9.8 is giving trouble. Check out this post/comment: teampoltergeist/poltergeist#340 (comment) Might be worth upgrading PhantomJS for the Travis builds, as these failed tests seem to be quite random. Locally I'm using version 2.1.1, which never failed for me. |
|
Moved to new PR so I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables you to inspect (for example) some AJAX requests made by the page that is visited, if the HTML of the page is not changed to reflect a success/error of the request (such as the Facebook api example).