Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "not initialized" warnings #107

Merged
merged 6 commits into from
Aug 25, 2015
Merged

Fix "not initialized" warnings #107

merged 6 commits into from
Aug 25, 2015

Conversation

algodave
Copy link
Contributor

I'm proposing this PR in order to avoid instance variable not initialized warnings

@ronwsmith
Copy link
Collaborator

Thanks for the contrib! When do you see these errors occurring?

@@ -16,7 +16,7 @@ def initialize
def start(threaded = true)
if threaded
Thread.new { main_loop }
sleep(0.01) while @signature.nil?
sleep(0.01) while (not defined?(@signature)) or @signature.nil?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do || here.

@algodave algodave changed the title Fix/not initialized warnings Fix "not initialized" warnings May 11, 2015
@algodave
Copy link
Contributor Author

@ronwsmith said

Thanks for the contrib! When do you see these errors occurring?

I'm using puffing-billy configured this way:

# in spec/support/billy.rb
Billy.configure do |c|
  c.cache = true
  c.persist_cache = true
end
Billy.config.logger.level = Logger::ERROR
Capybara.default_driver = :poltergeist_billy

# in my rspec contexts
      before do
        Billy.configure do |c|
          c.cache_path = 'spec/billy/my_context_path'
          c.merge_cached_responses_whitelist = [
            /useless-domain-one\.com/,
            /useless-domain-two\.com/
          ]
        end
      end

ronwsmith added a commit that referenced this pull request Aug 25, 2015
@ronwsmith ronwsmith merged commit a2800d4 into oesmith:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants