-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace travis with workflows, add 3.9 and remove 3.6 #746
Conversation
uvchik
commented
Feb 16, 2021
- solph will have to pay for Travis CI in the future
- Therefore we try to use github workflows instead
- We will test Python 3.9 from now on and drop 3.6 support
This will add the following tests:
Pytest/Checks is what Travis has done before, packing is new. I would suggest to add a black-style checker, but @oemof/oemof-solph should agree to that. |
I just added black to give you an idea how it would work. I fixed all issues but I can revert it if it is unwanted. I think auto-fixing is nice, too but you will have a Bot at the contributors. After a while the Bot may be one of the top ten developers. This is what I do not like, so I tend to not using the Bot. You have to change this value to true, to enable auto fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is pretty cool. As I said, the checks overview and the details for the checks could be a little tidier for me, but as you explained that's not on you, but rather on how GitHub picks what it wants to display. Concerning checking for properly formatted code in the tests, I'm all for it. This is a pretty cool PR. Thanks for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…and do a lot of style improvements.