Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis with workflows, add 3.9 and remove 3.6 #746

Merged
merged 11 commits into from
Feb 18, 2021

Conversation

uvchik
Copy link
Member

@uvchik uvchik commented Feb 16, 2021

  • solph will have to pay for Travis CI in the future
  • Therefore we try to use github workflows instead
  • We will test Python 3.9 from now on and drop 3.6 support

@uvchik uvchik self-assigned this Feb 16, 2021
@uvchik
Copy link
Member Author

uvchik commented Feb 16, 2021

This will add the following tests:

  • Pytest from tox.ini for 3.7, 3.8, 3.9 with coverage
  • Checks from tox.ini for 3.7, 3.8, 3.9 (twine, check-manifest, flake8, isort )
  • Packaging for 3.9

Pytest/Checks is what Travis has done before, packing is new.

I would suggest to add a black-style checker, but @oemof/oemof-solph should agree to that.

@uvchik
Copy link
Member Author

uvchik commented Feb 16, 2021

image image image

@pep8speaks
Copy link

pep8speaks commented Feb 16, 2021

Hello @uvchik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-16 16:57:52 UTC

@uvchik
Copy link
Member Author

uvchik commented Feb 16, 2021

I just added black to give you an idea how it would work. I fixed all issues but I can revert it if it is unwanted.

I think auto-fixing is nice, too but you will have a Bot at the contributors. After a while the Bot may be one of the top ten developers. This is what I do not like, so I tend to not using the Bot.

You have to change this value to true, to enable auto fixing.

@uvchik uvchik requested review from p-snft and gnn February 16, 2021 17:05
@uvchik uvchik modified the milestone: v0.4.2 Feb 16, 2021
Copy link
Member

@gnn gnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is pretty cool. As I said, the checks overview and the details for the checks could be a little tidier for me, but as you explained that's not on you, but rather on how GitHub picks what it wants to display. Concerning checking for properly formatted code in the tests, I'm all for it. This is a pretty cool PR. Thanks for doing this.

Copy link
Member

@p-snft p-snft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…and do a lot of style improvements.

setup.cfg Show resolved Hide resolved
@uvchik uvchik merged commit 86ff088 into dev Feb 18, 2021
@uvchik uvchik deleted the replace-travis-with-github-actions branch February 18, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants