Adjust indexing for content of InvestStorageBlock #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust indexing to be same as for content of storage without investment.
|
The file has a lot of duplication and should be reworked. But for now, I only want to provide a quick fix. PS: The code should be good already. Fixing the tests manually is a bit tedious, though. I will check the files that are automatically created and commit them without adjusting the line ordering to minimise changes. |
|
Turns out that the changed indexing also changes the results: Before, the initial storage level was given for the -1th time point, so the |
As we just want to test restoring a dumped file, I did not check if the new number is correct. As the time horozon is smaller, it makes sense that the storage is smaller, though.
|
This does not work as expected. Unfortunately, there is no real unit test for the storage. I will restart this attempt including a proper unit test. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1030