Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dockerbuild.sh #627

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

pbrier
Copy link
Contributor

@pbrier pbrier commented Sep 16, 2021

now run as user (instead of root) and fixed the autogeneration of version.c

@Wetmelon Wetmelon changed the base branch from master to fw-v0.5.4 September 29, 2021 22:31
@Wetmelon
Copy link
Collaborator

I don't see any issues with this. You're using it locally I assume?

@pbrier
Copy link
Contributor Author

pbrier commented Oct 3, 2021

Yes. This prevents 'root' owned files ending up in my directory.
It does not seem to pass the Ubuntu 16.04 build step in CI. Can I see somewhere why it failed?

@samuelsadok samuelsadok deleted the branch odriverobotics:devel October 12, 2021 14:24
@samuelsadok
Copy link
Member

Sorry, this closed automatically when deleting the target branch. If you want you can reopen it towards fw-v0.5.5. Ubuntu-16.04 is now removed from CI.

@madcowswe madcowswe reopened this Oct 21, 2021
@madcowswe madcowswe changed the base branch from fw-v0.5.4 to devel October 21, 2021 23:49
@madcowswe
Copy link
Member

madcowswe commented Oct 21, 2021

I fixed the branch delete issue by reinstating a devel branch. Thanks for your contribution.

@samuelsadok samuelsadok merged commit 341d727 into odriverobotics:devel Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants