[WIP] API Key flow #4
Conversation
| .modal(style="display:none;") | ||
| .jumbotron | ||
| ol | ||
| li Getting an API key requires a linked-credit card. |
views/api.jade
Outdated
| ol | ||
| li Calls over 25000/month will require an API key. | ||
| li Keyless API calls are limited to 1 call per second. Calls with API keys are limited to 3 calls per second. | ||
| li Getting an API key requires a linked-credit card. We'll automatically charge the card at the beginning of the month for any fees owed. |
views/api.jade
Outdated
| h4 Details | ||
| ol | ||
| li Calls over 25000/month will require an API key. | ||
| li Keyless API calls are limited to 1 call per second. Calls with API keys are limited to 3 calls per second. |
| table.table | ||
| tr | ||
| th First 25000 Calls/month | ||
| th Any Calls >25000/month |
There was a problem hiding this comment.
should be 25000+ calls/month?
There was a problem hiding this comment.
Well, even if they use 26000 calls, they'd only be paying for 1000 calls, so I think this is accurate wording.
| @@ -99,6 +102,9 @@ module.exports = function (db, redis) { | |||
| currency: 'usd', | |||
| source: token.id, | |||
| description: `Buying ${amount} cheese!`, | |||
| metadata: { | |||
| user: req.user ? req.user.account_id : "annon", | |||
| 'Did you enter the details correctly?'; | ||
| } else { | ||
| return 'There was a problem processing your request. ' + | ||
| 'If you keep getting errors, please contact us for support.'; |
|
|
||
| const api_key = uuid(); | ||
|
|
||
| const query = `INSERT INTO api_keys (account_id, api_key, customer_id) |
There was a problem hiding this comment.
parameterize the values instead of using string interpolation
|
|
||
| db.raw( | ||
| ` | ||
| SELECT |
| @@ -0,0 +1,160 @@ | |||
| const config = require('./config'); | |||
There was a problem hiding this comment.
Manually. We could probably set up a cron job, but I'd rather supervise it.
invoice.js
Outdated
| api_key | ||
| FROM api_key_usage | ||
| WHERE | ||
| timestamp <= '${invoiceMonth.endOf('month').format("YYYY-MM-DD")}' |
invoice.js
Outdated
|
|
||
| if (results.rows.length === 1 && results.rows[0].usage_count === e.usage_count) { | ||
|
|
||
| e.usage_count = 25001; |
There was a problem hiding this comment.
guessing this is just for testing
invoice.js
Outdated
| ); | ||
| } else { | ||
| console.error( | ||
| "[FAILED] Usage did not match count ad end of month. api_key", |
| @@ -71,29 +72,14 @@ app.use((req, res, cb) => { | |||
| }); | |||
|
|
|||
| app.use('/', donate(db, redis)); | |||
| app.use('/api', api(db, redis)); | |||
There was a problem hiding this comment.
should the api endpoints be implemented in core?
| @@ -26,6 +26,9 @@ const defaults = { | |||
| SESSION_SECRET: 'secret to encrypt cookies with', // string to encrypt cookies | |||
| COOKIE_DOMAIN: '', | |||
| GOAL: 5, // The cheese goal | |||
| API_PRICE: 1, | |||
| API_UNIT: 1, | |||
There was a problem hiding this comment.
Price = # calls / API_UNIT * API_PRICE
| @@ -26,6 +26,9 @@ const defaults = { | |||
| SESSION_SECRET: 'secret to encrypt cookies with', // string to encrypt cookies | |||
| COOKIE_DOMAIN: '', | |||
| GOAL: 5, // The cheese goal | |||
| API_PRICE: 1, | |||
| }); | ||
| }) | ||
| } else { | ||
| return res.render('api', { |
There was a problem hiding this comment.
this isn't really an API if you're rendering HTML?
There was a problem hiding this comment.
It's rendering the Jade file.
|
I feel there is a strong case to be made for porting this legacy code to React. It doesn't have to be the same app as webUI if you feel the domains are different, but I am a little concerned about adding new features to this code that we haven't maintained in years. |
No description provided.