Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update sphinxext submodule, closes #845 #846

Merged
merged 2 commits into from
Jan 22, 2017

Conversation

kohr-h
Copy link
Member

@kohr-h kohr-h commented Jan 22, 2017

No description provided.

@adler-j
Copy link
Member

adler-j commented Jan 22, 2017

I don't see any update performed to odlgroup/numpydoc, can that be correct? Or has the bugs we fixed locally been fixed upstream?

@kohr-h
Copy link
Member Author

kohr-h commented Jan 22, 2017

Well yeah, I rebased and force-pushed to master directly. But we still have the fixes as before, just off a more recent point.

@kohr-h
Copy link
Member Author

kohr-h commented Jan 22, 2017

So this PR only changes the submodule pointer to the new HEAD.

@kohr-h kohr-h mentioned this pull request Jan 22, 2017
3 tasks
Copy link
Member

@adler-j adler-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if it works for you then merge.

I'll test upstream.

@kohr-h
Copy link
Member Author

kohr-h commented Jan 22, 2017

Builds fine with the last fix, and submodule pointer is correct. Will merge after CI.

@kohr-h kohr-h merged commit 4a991e8 into odlgroup:master Jan 22, 2017
@kohr-h kohr-h deleted the issue-845__update_sphinxext branch January 22, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants