ENH: add per axis interpolation to DiscreteLp #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No tests? |
|
I can add some basic tests, sure, but the interpolation is being extensively tested already. |
|
Basic tests added. A said, we have some tests for the actual interpolation, this addition only concerns the interface. |
| raise ValueError("interpolation type '{}' not understood." | ||
| "".format(interp_in)) | ||
| self._interp = [interp] * partition.ndim | ||
| except TypeError: |
There was a problem hiding this comment.
What typeerror are we catching here?
There was a problem hiding this comment.
We catch the interp + '' error if interp is not a string-like type.
|
Looks good |
kohr-h
added a commit
that referenced
this pull request
Mar 9, 2016
ENH: add per axis interpolation to DiscreteLp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201.