-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance of the Mayo clinic human CT dataset loader #1589
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for going though the trouble to keep the Mayo dataset working! Please have a look at my review comments. They should be rather straightforward to address.
Regarding functionality, I trust that the changes you made work for you, so they're kind of tested. After all, it's in contrib
.
# define data folders | ||
proj_folder = odl.__path__[0] + '/../../data/LDCT-and-Projection-data/' \ | ||
'L004/08-21-2018-10971/1.000000-Full dose projections-24362/' | ||
rec_folder = odl.__path__[0] + '/../../data/LDCT-and-Projection-data/' \ | ||
'L004/08-21-2018-84608/1.000000-Full dose images-59704/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I suggest to use
odl.contrib.datasets.util.get_data_dir()
to determine a storage location. - What are the reasons to change the dataset directory? It would be good to have a small comment on top that says which data it is.
- Please use
dir
instead offolder
. The latter is Windows lingo, and Python uses e.g.is_dir()
to check if aPath
object represents a directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Mayo dataset cannot be downloaded directly from a url but it requires its own software. This prevents to use odl.contrib.datasets.util.get_data(filename, subset, url)
for local caching. Would this work better?
# define data folders | |
proj_folder = odl.__path__[0] + '/../../data/LDCT-and-Projection-data/' \ | |
'L004/08-21-2018-10971/1.000000-Full dose projections-24362/' | |
rec_folder = odl.__path__[0] + '/../../data/LDCT-and-Projection-data/' \ | |
'L004/08-21-2018-84608/1.000000-Full dose images-59704/' | |
# replace with your local directory | |
mayo_dir = '' | |
# define projection and reconstruction data directories | |
# e.g. for patient L004 full dose CT scan: | |
proj_dir = os.path.join( | |
mayo_dir, 'L004/08-21-2018-10971/1.000000-Full dose projections-24362/') | |
rec_dir = os.path.join( | |
mayo_dir, 'L004/08-21-2018-84608/1.000000-Full dose images-59704/') |
geometry, proj_data = mayo.load_projections(proj_folder, | ||
indices=slice(16000, 19000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above: why change the slice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been adjusted to the example considered (patient L004). In this case, the projection data counts ~32k images and the above slice choice reconstructs a central part of the volume.
5765d0a
to
96a7d5e
Compare
This branch updates the loader and utility code for the Mayo clinic human CT dataset. In particular:
src_shift_func
of theConeBeamGeometry
.