Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of FunctionSpaceElement on Operator #949

Closed
kohr-h opened this issue Mar 1, 2017 · 2 comments
Closed

Remove dependency of FunctionSpaceElement on Operator #949

kohr-h opened this issue Mar 1, 2017 · 2 comments

Comments

@kohr-h
Copy link
Member

kohr-h commented Mar 1, 2017

This was a lazy way of implementing function spaces in the first space. Probably the usefulness of all the Operator stuff is marginal. Removing this dependency would greatly improve the flexibility of vectorized functions, e.g.

>>> def f(x, c):
...     return sum(x) + c
...
>>> fspace = odl.FunctionSpace(odl.IntervalProd([0, 0], [1, 1]))
>>> f_elem = fspace.element(f)
>>> points = np.array([[0, 0], [0.5, 0], [1, 1]]).T
>>> f_elem(points, c=0)
array([ 0. ,  0.5,  2. ])
>>> f_elem(points, c=2)
array([ 2. ,  2.5,  4. ])

This is not possible currently because Operator has a very harsh signature restriction that is not needed here.

@adler-j
Copy link
Member

adler-j commented Mar 16, 2017

Fine by me!

@kohr-h
Copy link
Member Author

kohr-h commented Nov 13, 2017

Closed by #1088

@kohr-h kohr-h closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants