Skip to content

Commit

Permalink
Merge pull request #3842 from karl-zylinski/fix-poly-bitset-size
Browse files Browse the repository at this point in the history
Fix for bit_set[$T] proc params always being generated as i8
  • Loading branch information
Kelimion authored Jun 30, 2024
2 parents 4fbd22b + e0face1 commit efd933e
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/check_expr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,16 @@ gb_internal bool is_polymorphic_type_assignable(CheckerContext *c, Type *poly, T
if (!is_polymorphic_type_assignable(c, poly->BitSet.elem, source->BitSet.elem, true, modify_type)) {
return false;
}

// For generic types like bit_set[$T] the upper and lower of the poly type will be zeroes since
// it could not figure that stuff out when the poly type was created.
if (poly->BitSet.upper == 0 && modify_type) {
poly->BitSet.upper = source->BitSet.upper;
}
if (poly->BitSet.lower == 0 && modify_type) {
poly->BitSet.lower = source->BitSet.lower;
}

if (poly->BitSet.underlying == nullptr) {
if (modify_type) {
poly->BitSet.underlying = source->BitSet.underlying;
Expand Down

0 comments on commit efd933e

Please sign in to comment.