Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra metadata doc #114

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Extra metadata doc #114

merged 5 commits into from
Aug 23, 2024

Conversation

burnout87
Copy link
Contributor

No description provided.

volodymyrss
volodymyrss approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's wait for @ferrigno

ferrigno
ferrigno requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ferrigno ferrigno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful.

Suggested change:
oda:group: to visually group together a set of parameters -> ```oda:group: to visually group together a set of parameters horizontally`

It would be a nice addition to make Vertical "Blocks" of parameters and to control the order of presentation of parameters.

@burnout87
Copy link
Contributor Author

It would be a nice addition to make Vertical "Blocks" of parameters and to control the order of presentation of parameters.

As for the order, it is actually something already discussed here oda-hub/frontend-tab-generator#25

@burnout87 burnout87 requested a review from ferrigno August 23, 2024 07:37
@burnout87 burnout87 merged commit 2d19f90 into master Aug 23, 2024
2 checks passed
@dsavchenko
Copy link
Member

and to control the order of presentation of parameters.

As for the order, it is actually something already discussed here oda-hub/frontend-tab-generator#25

The order is preserved already for quite some time. I closed the corresponding issue.

@volodymyrss volodymyrss linked an issue Aug 27, 2024 that may be closed by this pull request
Add documentation for Get direct annotation functionality #106
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavchenko dsavchenko dsavchenko approved these changes

@volodymyrss volodymyrss volodymyrss approved these changes

@ferrigno ferrigno ferrigno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for Get direct annotation functionality
4 participants
@burnout87 @dsavchenko @ferrigno @volodymyrss