Fix order of steps in lint-fmt job #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworking fixing an error I introduced in ocurrent#937
|
Huh... looking at the history here, I am quite confused about why I didn't merge this into master in the first place via my PR, why it was deployed an not merged etc... :/ I clearly messed up there, so thanks for the fix. IMO, this points to the need for a cleaner CD story here (and a staging env so we don't need to test on prod). But those needs are tracked already. Thank you for the fix and sorry for the trouble! |
shonfeder
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking fixing an error Shon introduced in
#937
This commit is on
live-enginebut does not appear onmaster