Add support for Docker/Windows spec #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
requested review from
talex5 and
tmcgilchrist
and removed request for
talex5
tmcgilchrist
reviewed
Sep 8, 2022
MisterDA
force-pushed
the
docker-windows-spec
branch
from
28b3213 to
ff72822
Compare
|
Applied your suggestions, thanks. |
tmcgilchrist
approved these changes
Sep 19, 2022
MisterDA
force-pushed
the
docker-windows-spec
branch
from
ff72822 to
5d55aac
Compare
|
Updated the base Windows image, good to go. |
kit-ty-kate
reviewed
Sep 20, 2022
MisterDA
force-pushed
the
docker-windows-spec
branch
from
5d55aac to
8886420
Compare
tmcgilchrist
approved these changes
Sep 21, 2022
7 tasks
MisterDA
force-pushed
the
docker-windows-spec
branch
3 times, most recently
from
748619b to
7e02f0c
Compare
|
These amended patches finally fix the spec tests on Windows. Please consider for merging. |
Otherwise embedded text get crlf line endings.
MisterDA
force-pushed
the
docker-windows-spec
branch
from
7e02f0c to
6c01963
Compare
tmcgilchrist
approved these changes
Oct 14, 2022
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Nov 7, 2022
CHANGES: - Add --fuse-path to allow selection of the path redirected by FUSE (@mtelvers ocurrent/obuilder#128, reviewed by @MisterDA ) - Pre-requisites for Windows support using docker for Windows (@MisterDA ocurrent/obuilder#116, reviewed by @tmcgilchrist) - Additional tests and prerequistes for Windows support (@MisterDA ocurrent/obuilder#130, reviewed by @tmcgilchrist) - Add support for Docker/Windows spec (@MisterDA ocurrent/obuilder#117, reviewed by @tmcgilchrist) - Depend on Lwt.5.6.1 for bugfixes (@MisterDA ocurrent/obuilder#108, reviewed by @tmcgilchrist) - Add macOS support (@patricoferris ocurrent/obuilder#87, reviewed by @tmcgilchrist @talex5 @kit-ty-kate) - Enable macOS tests only on macOS (@MisterDA ocurrent/obuilder#126, reviewed by @tmcgilchrist) - Dune 3.0 generates empty intf for executables (@MisterDA ocurrent/obuilder#111, reviewed by @talex5) - Fix warnings and CI failure (@MisterDA ocurrent/obuilder#110, reviewed by @talex5) - Expose store root and cmdliner term with non-required store (@MisterDA ocurrent/obuilder#119, reviewed by @tmcgilchrist) - Expose Rsync_store module (@MisterDA ocurrent/obuilder#114, reviewed by @talex5) - Rsync hard-links to save space (@art-w ocurrent/obuilder#102, reviewed by @patricoferris)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit setting
safe.directoryshall be removed when our base images start shipping with