Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run opam init in OS base image #66

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Run opam init in OS base image #66

merged 1 commit into from
Oct 26, 2020

Conversation

dra27
Copy link
Contributor

@dra27 dra27 commented Oct 26, 2020

Split off from #65

Initialise opam without a switch in the OS base image - each compiler
container then merely adds a switch.
@talex5 talex5 merged commit 164d359 into ocurrent:master Oct 26, 2020
@talex5
Copy link
Contributor

talex5 commented Oct 26, 2020

It's live and building images now: https://base-images.ocamllabs.io/

@dra27
Copy link
Contributor Author

dra27 commented Oct 26, 2020

Be very afraid 😈

@kit-ty-kate
Copy link
Contributor

This change just broke opam-health-check as it's using the base image with opam 2.1 and now requires user input to upgrade the ~/.opam directory

Step 19/22 : RUN opam switch create --repositories=alpha,beta,default 4.11.1
 ---> Running in 13933edfa09d
This development version of opam requires an update to the layout of /home/opam/.opam from version 2.0 to version 2.1, which can't be reverted.
You may want to back it up before going further.
Continue? [Y/n] n

it's not a big deal but just so you know for next time.

@dra27
Copy link
Contributor Author

dra27 commented Oct 28, 2020

If opam-health-check’s overriding opam, would it be better for it to be using an image at an earlier stage of the pipeline? Or should there therefore be an earlier stage? Each compiler container having to init opam itself ground my poor mechanical disk to a halt 🙂

@kit-ty-kate
Copy link
Contributor

It's ok I just fixed it in kit-ty-kate/opam-health-check-ng@baaa4fd. It's not too much of a bother to me since I only do this step once.
However I was surprised by the behaviour of opam init there so I opened an issue: ocaml/opam#4409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants