Include the base branch path in pull URLs #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2bc44e changed the URL path to include the name of the base branch against a pull-request has been opened. This commit fixes the URLs for pulls shared in Slack notifications.
|
LGTM! |
ElectreAAS
approved these changes
May 3, 2023
|
Haha, yes, I was trying to look at the queue of work being processed by current-bench after the latest deploy which added a bunch of benchmarks to be run on the |
|
Thanks for the review and the merge, @ElectreAAS ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a2bc44e changed the URL path to include the name of the base branch against a pull-request has been opened. This commit fixes the URLs for pulls shared in Slack notifications.
Also, re-use code from
to_pathingithub_status_urlfunction. Fixes #435.