Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ [ FEAT REQ ] Outdated MMS Config Database #36

Closed
celenityy opened this issue Dec 15, 2023 · 12 comments · Fixed by #103 or #153
Closed

✏️ [ FEAT REQ ] Outdated MMS Config Database #36

celenityy opened this issue Dec 15, 2023 · 12 comments · Fixed by #103 or #153
Labels
enhancement New feature or request important

Comments

@celenityy
Copy link

Is your feature request related to a problem? If so, please describe the problem.
Quik is currently using a very outdated MMS config database from January 2018, that it inherited from QKSMS. It can be found here. This can cause issues with MMS compatibility and reliability.

Describe the feature you'd like
I'd like to see Quik use an updated MMS config database. For instance, GrapheneOS uses the same database as Google Messages for their included Messaging app, see here. This database is much more up to date.

Additional context
See @SkewedZeppelin's comments here and here.

@celenityy celenityy added the enhancement New feature or request label Dec 15, 2023
@octoshrimpy
Copy link
Owner

Will be looking into this for the next release, as this seems important.

@octoshrimpy
Copy link
Owner

@Retold3202 I'm tackling this now, and after looking over everything, I think I understand what needs to be done, but not quite what needs to change, code-wise.

@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Dec 16, 2023

@octoshrimpy
it shouldn't need any code changes, just dump the new ones into res/, but there is a possible question of licensing

@octoshrimpy
Copy link
Owner

@SkewedZeppelin Hey, great to see you here!

Good point on licensing. Do you know where I should start looking into that? maybe grapheneOS license, maybe?

@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Dec 16, 2023

@octoshrimpy
no, you must understand those configs are dumped from decompiled Google Messages.
they are a legal grey area in that regard, but there is unlikely any other source to get them from, and they could be argued as constants, ianal

@allanonmage
Copy link

Oh is that why QKSMS MMS broke a few years ago? What does this configuration do that the APN on the network doesn't?

I tried to go look at them, and on the GrapheneOS page, there's a bunch of stuff about translations, so maybe I missed something.

@SkewedZeppelin
Copy link
Contributor

@allanonmage
APN configs are distinct from MMS configs.

@allanonmage
Copy link

allanonmage commented Dec 28, 2023

Well now that the open source community has some code about all this, maybe I can figure out what's what and why MMS has never really worked on my phone whenever I load custom ROMs and stuff to it, for, oh, like 15 years or so.

@snaggen
Copy link

snaggen commented Mar 13, 2024

About the licensing? Is that really any different from the existing outdated mms config? A assume they were aquired in the same/similar way?
I think upgrading will not change the situation in this regard, but IANAL so... but if someone would raise an issue about it, then you can always revert.

I think updating this configs to get MMS working properly should be quite high on the priority list....

@octoshrimpy
Copy link
Owner

@snaggen : agreed. Pinning this so when I get some time this is my first priority

@Jeroslav
Copy link

Hello, I'm happy to use this app. Thank You. I also have a problem with send eg. photos via MMS. @octoshrimpy I'm sorry for escalating problem, but I wanted to ask you if implementation date is known? (the problem has already been reported some time ago)

@celenityy
Copy link
Author

Hopefully this can eventually be implemented, I would love to be able to stop using the stock AOSP Messaging app...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important
Projects
None yet
7 participants
@allanonmage @snaggen @octoshrimpy @SkewedZeppelin @celenityy @Jeroslav and others